Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move VERSION to src/folder #1148 #1149

Merged
merged 3 commits into from
Dec 2, 2022
Merged

refactor: move VERSION to src/folder #1148 #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a4ce4
Refactor: move VERSION to src/folder
CNLHC Dec 1, 2022
b312f97
try to fix failed test
CNLHC Dec 1, 2022
3ab8b1f
refactor: change .version to version.txt
CNLHC Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ list(APPEND EXTERNAL_LIBS Threads::Threads)

# Add git sha to version.h
find_package(Git REQUIRED)
execute_process(COMMAND sh -c "cat VERSION"
execute_process(COMMAND sh -c "cat src/VERSION.txt"
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR} OUTPUT_VARIABLE PROJECT_VERSION)
execute_process(COMMAND git rev-parse --short HEAD
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR} OUTPUT_VARIABLE GIT_SHA)
Expand Down
0 VERSION → src/VERSION.txt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion x.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def write_version(release_version: str) -> str:
if SEMVER_REGEX.match(version) is None:
raise RuntimeError(f"Kvrocks version should follow semver spec, got: {version}")

with open('VERSION', 'w+') as f:
with open('src/VERSION.txt', 'w+') as f:
f.write(version)

return version
Expand Down