Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old string parsing util and replace them by ParseInt #1191

Merged
merged 2 commits into from
Dec 18, 2022
Merged

Remove old string parsing util and replace them by ParseInt #1191

merged 2 commits into from
Dec 18, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Dec 17, 2022 •
edited
Loading

We remove DecimalStringToNum and OctalStringToNum in this PR, since they are hard to use and too less general than ParseInt (e.g. the parsed integer type cannot be changed), and they are just wrappers of ParseInt after we introduce ParseInt.

torwig
torwig approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 0d66626 into apache:unstable Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig