Refactor return value of functions that related to a slot migration #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torwig
force-pushed
the
refactor_slot_migrate
branch
from
13adfe0
to
ddb9345
Compare
git-hulk
approved these changes
Dec 26, 2022
caipengbo
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make functions return the value of type
Statusinstead ofbool.Log errors on a higher level by passing error messages to the caller via
Status.Tidy the constructor of the
SlotMigrateclass.@PragmaTwice The
.Prefixedmethod of theStatustype helped me a lot to make this refactoring. Thank you :)