Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config parsing in kvrocks2redis #1221

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Refactor config parsing in kvrocks2redis #1221

merged 2 commits into from
Jan 12, 2023

Conversation

PragmaTwice
Copy link
Member

torwig
torwig approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit 2fd1aac into apache:unstable Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong substring in kvrocks2redis config
3 participants
@PragmaTwice @git-hulk @torwig