Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the RocksDB WriteBatchWithIndex to implement the read-your-own-writes in transaction #1287

Merged
merged 13 commits into from
Mar 4, 2023
Merged

Use the RocksDB WriteBatchWithIndex to implement the read-your-own-writes in transaction #1287

merged 13 commits into from
Mar 4, 2023

Commits on Mar 2, 2023

  1. Use the shared_ptr in WriteBatch

    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    f3cd480 View commit details
    Browse the repository at this point in the history

  2. Use WriteBatchBase to replace the WriteBatch

    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    721db80 View commit details
    Browse the repository at this point in the history

  3. Use the RocksDB WriteBatchWithIndex to implement the 

    read-your-own-writes in transaction

By default, the writes cannot be seen its own writes if the WriteBatch
wasn't committed in transaction. To mitigate this issue, RocksDB offers
the WriteBatchWithIndex to make the uncommitted writes can be visited.

For more information can see: https://rocksdb.org/blog/2015/02/27/write-batch-with-index.html
    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    433a550 View commit details
    Browse the repository at this point in the history

  4. Reduce the stream insert size to avoid timeout

    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b15b387 View commit details
    Browse the repository at this point in the history

  5. Add OberserverOrUniquePtr to replace the shared_ptr

    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    58c18ac View commit details
    Browse the repository at this point in the history

  6. Remove the db pointer from the Redis::Database

    @git-hulk
    git-hulk committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c7ff226 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Resolve review comments

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    309c572 View commit details
    Browse the repository at this point in the history

  2. Add a new function writeToDB to make it clear

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    b8b5a6b View commit details
    Browse the repository at this point in the history

  3. Add the move constrcutor

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    ece2b81 View commit details
    Browse the repository at this point in the history

  4. Fix format

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    d7e1440 View commit details
    Browse the repository at this point in the history

  5. Remove static_cast and rename private variable with underscore suffix

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    cf34a42 View commit details
    Browse the repository at this point in the history

  6. Use Release to replace the nullptr

    @git-hulk
    git-hulk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    319a2c1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'unstable' into atomic-exec-command

    @git-hulk
    git-hulk authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a81ea45 View commit details
    Browse the repository at this point in the history