Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit fallthrough in the replication state transmission #1293

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

mzygQAQ
Copy link
Contributor

@mzygQAQ mzygQAQ commented Mar 1, 2023

I found that this project completely adopts c++17, so I'm not going to use the following tedious macro definitions:

#if HAS_CPP17_ATTRIBUTE(fallthrough)
#  define FALLTHROUGH [[fallthrough]]
#elif defined(__clang__)
#  define FALLTHROUGH [[clang::fallthrough]]
#elif GCC_VERSION >= 700 && \
    (!defined(__EDG_VERSION__) || __EDG_VERSION__ >= 520)
#  define FALLTHROUGH [[gnu::fallthrough]]
#else
#  define FALLTHROUGH
#endif

@PragmaTwice PragmaTwice linked an issue Mar 2, 2023 that may be closed by this pull request
2 tasks
@PragmaTwice
Copy link
Member

@guoxiangCN Thanks for your contribution!

@PragmaTwice PragmaTwice merged commit f3e391c into apache:unstable Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe add a explicit [[fallthough]] is more better to the source readers
5 participants