Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MEMORY USAGE command as an alias to existing DISK USAGE command #1375

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Apr 8, 2023

Since Redis has the MEMORY command, tools like RedisInsight use it to show information to the user.
Currently, RedisInsight can't show memory usage by keys because Kvrocks doesn't support the MEMORY USAGE command.
Solution: make the MEMORY USAGE command an alias to the DISK USAGE command.
Currently, the MEMORY USAGE command doesn't support the optional SAMPLES option.
The integration test basically checks that Kvrocks support the new command and the response is an integer value conforming to the Redis spec.

@aleksraiden
Copy link
Contributor

Good, thanks! Now I use a redisInsight tool im work and we have two separated service, redis and kvroks, and this features very good to me!

@git-hulk
Copy link
Member

git-hulk commented Apr 9, 2023

Thanks all, merging...

@git-hulk git-hulk merged commit f089758 into apache:unstable Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants