Add MEMORY USAGE command as an alias to existing DISK USAGE command #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Redis has the
MEMORY
command, tools likeRedisInsight
use it to show information to the user.Currently,
RedisInsight
can't show memory usage by keys becauseKvrocks
doesn't support theMEMORY USAGE
command.Solution: make the
MEMORY USAGE
command an alias to theDISK USAGE
command.Currently, the
MEMORY USAGE
command doesn't support the optionalSAMPLES
option.The integration test basically checks that
Kvrocks
support the new command and the response is an integer value conforming to the Redis spec.