Add a particular test case for HGETALL with async_io=true #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was reproducible with RocksDB v8.0.0, large values in a hash set (>512 bytes). After the COMPACT command was executed, HGETALL/HVALS/HKEYS couldn't "see" all the elements of the hash set. However, HGET could find those values. It looked like the iterator via the snapshot didn't see them for some reason. Since the version of the RocksDB was bumped to v8.0.1, the bug disappeared.
|
@torwig thanks for help in discovering this bug |
tisonkun
reviewed
Apr 23, 2023
|
|
||
| require.NoError(t, rdb.Do(ctx, "COMPACT").Err()) | ||
|
|
||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
Is it possible to be unstable?
There was a problem hiding this comment.
What do you mean by unstable? Since the COMPACT command is asynchronous, I add the time.Sleep call here.
There was a problem hiding this comment.
Thanks for your explanation :)
Generally, sleep is unpredictable, so it may sleep too short and miss the correct condition. I asked here for more background. If we cannot have a determinate latch for COMPACT completion, I'm OK with current way.
|
Ooops, not the correct branch. I'll re-push now. |
|
Now it's OK. |
tisonkun
approved these changes
Apr 24, 2023
git-hulk
approved these changes
Apr 24, 2023
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was reproducible with RocksDB v8.0.0, large values in a hash set (>512 bytes).
After the COMPACT command was executed, HGETALL/HVALS/HKEYS couldn't "see" all the elements of the hash set. However, HGET could find those values.
It looked like the iterator via the snapshot didn't see them for some reason.
Since the version of the RocksDB was bumped to v8.0.1, the bug disappeared.
Adding the test case to prevent facing this bug in the future.
This is the output of the failed test: