Feat: Block instance replication of itself and it's own replicas #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @uds5501, you need to fix the clang-tidy error: https://github.com/apache/incubator-kvrocks/actions/runs/5199313230/jobs/9376587287?pr=1488#step:8:1166 to pass the CI. And can you add some Go tests to make sure it works? |
|
@git-hulk , added integration test and clang-tidy error |
Thanks for your efforts |
git-hulk
force-pushed
the
patch_self_replication
branch
from
7d52858
to
cfe0047
Compare
PragmaTwice
reviewed
Jun 11, 2023
Co-authored-by: Twice <[email protected]>
git-hulk
approved these changes
Jun 12, 2023
|
Thanks all, merging... |
|
@uds5501 Thanks for your contribution. |
jihuayu
pushed a commit
to jihuayu/incubator-kvrocks
that referenced
this pull request
Jun 16, 2023
…pache#1488) Co-authored-by: git-hulk <[email protected]> Co-authored-by: Twice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: A patch to block an instance from replicating itself and it's own replicas
Fixes: #1484