LSET return no suck key instread of NotFound when key not exist #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code directly returns s.ToString() in this case: ``` 127.0.0.1:6666> lset nokey 0 1 (error) ERR NotFound: ``` NotFound might not be that friendly, and there's an extra `:` after it. Modify it to return no such key: ``` 127.0.0.1:6666> lset nokey 0 1 (error) ERR no such key ``` Note Redis also return the no such key error in this case, so it should be fine returning this error.
git-hulk
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code directly returns s.ToString() in
this case:
NotFound might not be that friendly, and there's an
extra
:after it. Modify it to return no such key:Note Redis also return the no such key error in this
case, so it should be fine returning this error.