Make INFO command reject cases with arguments greater than 2 #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `info a b c` is the same as passing plain `info`, since we only checked that args_.size() == 2, by default it will output all. In this PR, we will reject args_.size() > 2 and return a syntax error. This is consistent with Redis 6.2 behavior, however, it is inconsistent with Redis 7.0, Redis 7.0 supports passing `info server clients ...`. Because we don't plan to do such support for the time being, we will first fix the parts that are obviously problematic.
git-hulk
approved these changes
Jul 9, 2023
PragmaTwice
approved these changes
Jul 9, 2023
PragmaTwice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
info a b cis the same as passing plaininfo,since we only checked that args_.size() == 2, by default it
will output all.
In this PR, we will reject args_.size() > 2 and return a
syntax error. This is consistent with Redis 6.2 behavior,
however, it is inconsistent with Redis 7.0, Redis 7.0 supports
passing
info server clients ....Because we don't plan to do such support for the time being,
we will first fix the parts that are obviously problematic.