Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version typo in variable name #1591

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

enjoy-binbin
Copy link
Member

No description provided.

@enjoy-binbin
Copy link
Member Author

enjoy-binbin commented Jul 13, 2023

maybe we can add a spell check ci?

I have added this spell check ci to Redis in the past: https://github.com/redis/redis/blob/unstable/.github/workflows/spell-check.yml

Redis spell check PR link: redis/redis#8890

I can try to add it if I get the conceptual approval.

here is an example: https://github.com/redis/redis/actions/runs/5309794414
ci checks take very little time (tens of seconds)

@git-hulk git-hulk merged commit 0d23043 into apache:unstable Jul 13, 2023
@enjoy-binbin enjoy-binbin deleted the fix_version_typo branch July 13, 2023 12:13
git-hulk pushed a commit to git-hulk/kvrocks that referenced this pull request Jul 30, 2023
@git-hulk git-hulk mentioned this pull request Jul 31, 2023
git-hulk pushed a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants