Simply test the built docker image in CI

[PragmaTwice]

It closes #1580.

In nightly CI, we have built docker images for kvrocks, but we cannot confirm the built docker image is valid, e.g. the kvrocks may just crash after starting due to some OS environment problems, like shared library missing. We want to add some simple test to confirm the built image is run-able.

[tisonkun]

We can test before release, like https://github.com/korandoru/hawkeye/blob/75da87606f8f303c740d8d8d6738d8271af90d0a/.github/workflows/ci.yml#L94-L119

Or even add the extra test step at -

kvrocks/.github/workflows/kvrocks.yaml

Lines 280 to 292 in f3d3105

	check-docker:
	name: Check Docker image
	needs: [precondition, check-and-lint]
	if: ${{ needs.precondition.outputs.docs_only != 'true' }}
	runs-on: ubuntu-20.04
	steps:
	- uses: actions/checkout@v3
	- name: Get core numbers
	run: echo "NPROC=$(nproc)" >> $GITHUB_ENV
	- uses: docker/build-push-action@v3
	with:
	context: .
	build-args: MORE_BUILD_ARGS=-j${{ env.NPROC }}

So we check before merge.

[PragmaTwice]

Or even add the extra test step at -

Seems a good idea, but I do not know how to get the docker image in the previous step (docker/build-push-action@v3) since we do not push it.

kvrocks/.github/workflows/kvrocks.yaml

Line 289 in f3d3105

- uses: docker/build-push-action@v3

[PragmaTwice]

And, a failed try by me, is that uses: docker://apache/kvrocks:nightly does not work, seems the asf github settings have blocked them.

[tisonkun]

@PragmaTwice I already link to this snippet which has a step to "Build and load".

      - name: Build and load
        uses: docker/build-push-action@v3
        with:
          context: .
          file: ${{matrix.file}}
          tags: ${{matrix.name}}:ci
          outputs: type=docker
      - name: Sanity check
        run: docker run --rm -v $(pwd):/github/workspace ${{matrix.name}}:ci check

Take care of outputs and the sanity check step we use docker run.

[PragmaTwice]

@PragmaTwice I already link to this snippet which has a step to "Build and load".

      - name: Build and load
        uses: docker/build-push-action@v3
        with:
          context: .
          file: ${{matrix.file}}
          tags: ${{matrix.name}}:ci
          outputs: type=docker
      - name: Sanity check
        run: docker run --rm -v $(pwd):/github/workspace ${{matrix.name}}:ci check

Take care of outputs and the sanity check step we use docker run.

Got it. Done.

[tisonkun]

LGTM. Please update the PR title according to the current change.