-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add typos check #1663
ci: add typos check #1663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently "Install typos-cli" step takes 2-3 minutes 😲 This takes 1 second 🐎 |
I saw similar trick in OpenDAL. Let me try it out. Actually we may make use of Rust GHA cache. But it's an action beyond the approved ones so I may postpone a bit for using it. |
@szepeviktor I found that typos upstream provides an action already and thus I'm making use of it :D Maybe you can switch to this solution also. |
@tisonkun Here are some facts for you.
These made me rewrite it in 6 commands. |
@szepeviktor thanks for your advice. Also the action isn't approved by INFRA yet. May you create a pr onto my with your installation solution? That is, open a PR against this one, Or use suggestions. |
I am sorry. I cannot contribute here. My solution needs hard-wired excludes etc. |
ASF repo does not allow to use action like |
@PragmaTwice No. It's the action itself not approved, not the version the issue. So we can either ask INFRA to approve or use a non-action solution. I'm going to reuse @szepeviktor's solution in https://github.com/szepeviktor/byte-level-care under MIT license. |
Or just OpenDAL's for simplicity. |
@torwig @PragmaTwice Kvrocks failed to build. Do you have any idea - https://github.com/apache/kvrocks/actions/runs/5827809599/job/15805697484?pr=1663? |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Co-authored-by: Viktor Szépe <[email protected]>
Signed-off-by: tison <[email protected]>
Co-authored-by: Viktor Szépe <[email protected]>
Signed-off-by: tison <[email protected]>
This PR adds a typo checker CI action that will fail future PRs if they introduce typos and spelling mistakes. This supersedes and thus closes apache#1660. Signed-off-by: tison <[email protected]> Co-authored-by: Viktor Szépe <[email protected]>
This PR adds a typo checker CI action that will fail
future PRs if they introduce typos and spelling mistakes.
This supersedes and thus closes #1660.