Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable building of the unused shared library for jemalloc #1695

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jonahgao
Copy link
Member

$ ls kvrocks/build/_deps/jemalloc-build/lib
libjemalloc.a  libjemalloc_pic.a  libjemalloc.so  libjemalloc.so.2

It appears that the shared library is not being utilized.

@git-hulk
Copy link
Member

@jonahgao Thanks for your good catch. That's right that we don't use the shared library.

Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@git-hulk git-hulk merged commit 04dc335 into apache:unstable Aug 24, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants