Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GETEX not working correctly on Redis::Bitmap #1743

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Fix GETEX not working correctly on Redis::Bitmap #1743

merged 7 commits into from
Sep 7, 2023

Conversation

gogim1
Copy link
Contributor

@gogim1 gogim1 commented Sep 6, 2023 •
edited
Loading

The expiration time of a Redis::Bitmap cannot be changed by GETEX, this PR solves the problem.

@gogim1 gogim1 changed the title Fix GETEX not working on Redis::Bitmap Fix GETEX not working correctly on Redis::Bitmap Sep 6, 2023
@git-hulk
Copy link
Member

git-hulk commented Sep 6, 2023

@gogim1 Thanks for your good catch.

@mapleFU
Copy link
Member

mapleFU commented Sep 6, 2023

@git-hulk Would the expired subkey finally cleared by compaction filter?

@git-hulk
Copy link
Member

git-hulk commented Sep 6, 2023

@git-hulk Would the expired subkey finally cleared by compaction filter?

Yes, exactly.

git-hulk
git-hulk reviewed Sep 6, 2023
View reviewed changes
src/commands/cmd_string.cc Outdated Show resolved Hide resolved
@gogim1
fix: error handing
13b6f78 
Signed-off-by: Jinze Wu <[email protected]>
@gogim1
Copy link
Contributor Author

gogim1 commented Sep 7, 2023

Changes have been made in response to the comments above. PTAL. :)

@gogim1
fix
929a9a5 
Signed-off-by: Jinze Wu <[email protected]>
mapleFU
mapleFU approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 59012ac into apache:unstable Sep 7, 2023
26 checks passed
@gogim1 gogim1 deleted the getex-bitmap branch September 7, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice left review comments

@mapleFU mapleFU mapleFU approved these changes

@enjoy-binbin enjoy-binbin enjoy-binbin approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gogim1 @git-hulk @mapleFU @PragmaTwice @enjoy-binbin