Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing const specifiers to methods #1744

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add missing const specifiers to methods #1744

merged 2 commits into from
Sep 7, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Sep 6, 2023 •
edited
Loading

In this PR, we added lots of missing const specifiers to class methods.

@PragmaTwice PragmaTwice changed the title Add missing const specifier to methods Add missing const specifiers to methods Sep 6, 2023
torwig
torwig approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mapleFU
mapleFU approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, can we enable some clang checkings or other lint checkings after this patch is merged?

@PragmaTwice
Copy link
Member Author

BTW, can we enable some clang checkings or other lint checkings after this patch is merged?

It is enabled, but it cannot find every missing specifier.

@PragmaTwice PragmaTwice merged commit 45d741a into apache:unstable Sep 7, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @git-hulk @torwig @mapleFU