Fix TYPE command with bloom filter
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinze Wu <[email protected]>
PragmaTwice
reviewed
Sep 8, 2023
gogim1
changed the title
TYPE command with bloom filter
|
Also cc @zncleon |
|
This patch is LGTM. Would you mind add a tiny test in |
Signed-off-by: Jinze Wu <[email protected]>
done |
mapleFU
previously approved these changes
Sep 8, 2023
Signed-off-by: Jinze Wu <[email protected]>
PragmaTwice
previously approved these changes
Sep 8, 2023
enjoy-binbin
reviewed
Sep 8, 2023
| @@ -37,6 +37,7 @@ class CommandType : public Commander { | |||
| RedisType type = kRedisNone; | |||
| auto s = redis.Type(args_[1], &type); | |||
| if (s.ok()) { | |||
| if (type >= RedisTypeNames.size()) return {Status::RedisExecErr, "Invalid type"}; | |||
There was a problem hiding this comment.
i think in this case we can trigger a crash instead of returning an error.
returning an error will make the user think he is doing something wrong,
when in fact this is a kvrocks internally bug (user can fire a issue and report this)
but i am also ok with it since mostly it will be a dead code.
(actually returning nothing seems better than returning an error)
please also add a comment near by RedisType and RedisTypeNames, mention that they need to stay in sync
Signed-off-by: Jinze Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #1699 introduced BloomFilter, RedisTypeNames was not modified
at the same time, causing the TYPE command return nothing in bf key.
Now it will return
MBbloom--(keep names consistent with Redis).