Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing return value receiver when using Go's slices.Compact #1771

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix missing return value receiver when using Go's slices.Compact #1771

merged 1 commit into from
Sep 20, 2023

Conversation

git-hulk
Copy link
Member

This closes #1770

tisonkun
tisonkun approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Merging..

While I'm curious why we don't get a failure previously.

@tisonkun tisonkun merged commit 49c6248 into apache:unstable Sep 20, 2023
26 checks passed
@tisonkun tisonkun mentioned this pull request Sep 20, 2023
Closed
2 tasks
@git-hulk
Copy link
Member Author

Thank you!

Merging..

While I'm curious why we don't get a failure previously.

Guess we don't have duplicate elements when scanning, so slices.Compact would do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slices.Compact
5 participants
@git-hulk @torwig @tisonkun @PragmaTwice @mapleFU