Add the support of JSON.TYPE command #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
requested review from
PragmaTwice,
mapleFU and
torwig
and removed request for
PragmaTwice
PragmaTwice
reviewed
Oct 21, 2023
PragmaTwice
reviewed
Oct 21, 2023
PragmaTwice
reviewed
Oct 21, 2023
Co-authored-by: Twice <[email protected]>
Co-authored-by: Twice <[email protected]>
PragmaTwice
reviewed
Oct 21, 2023
Co-authored-by: Twice <[email protected]>
PragmaTwice
approved these changes
Oct 21, 2023
mapleFU
reviewed
Oct 21, 2023
Comment on lines
+150
to
+151
| case jsoncons::json_type::double_value: | ||
| types->emplace_back("number"); |
| case jsoncons::json_type::double_value: | ||
| types->emplace_back("number"); | ||
| break; | ||
| case jsoncons::json_type::string_value: |
There was a problem hiding this comment.
I think it is not a type in JSON documents.
PragmaTwice
added a commit
to apache/kvrocks-website
that referenced
this pull request
Oct 21, 2023
PragmaTwice
added a commit
to apache/kvrocks-website
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1826
For the JSON type mapping, please refer: https://github.com/RedisJSON/RedisJSON/blob/ecede3c314851ccbc793d976c890bf9ea291a371/redis_json/src/key_value.rs#L378