Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support JSON.NUMINCRBY and JSON.NUMMULTBY command #1890

Merged
merged 1 commit into from
Dec 1, 2023
Merged

support JSON.NUMINCRBY and JSON.NUMMULTBY command #1890

merged 1 commit into from
Dec 1, 2023

Conversation

skyitachi
Copy link
Contributor

@skyitachi skyitachi mentioned this pull request Nov 10, 2023
Closed
git-hulk
git-hulk reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left some comments.

@skyitachi It's good to add Go tests only if codes can be covered. C++ tests only required when some critical codes cannot be tested by Go tests.

src/commands/cmd_json.cc Outdated Show resolved Hide resolved
src/commands/cmd_json.cc Outdated Show resolved Hide resolved
src/types/redis_json.cc Outdated Show resolved Hide resolved
src/types/json.h Outdated Show resolved Hide resolved
@skyitachi
Copy link
Contributor Author

Overall looks good, left some comments.

@skyitachi It's good to add Go tests only if codes can be covered. C++ tests only required when some critical codes cannot be tested by Go tests.

got it

git-hulk
git-hulk previously approved these changes Nov 12, 2023
View reviewed changes
@git-hulk
Copy link
Member

@skyitachi Can you help to resolve conflicts before merging?

git-hulk
git-hulk previously approved these changes Nov 13, 2023
View reviewed changes
PragmaTwice
PragmaTwice reviewed Nov 13, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Nov 13, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
git-hulk
git-hulk previously approved these changes Nov 19, 2023
View reviewed changes
PragmaTwice
PragmaTwice reviewed Nov 20, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
This was linked to issues Nov 20, 2023
Add support for the JSON.NUMINCRBY command #1818
Closed
Add support for the JSON.NUMMULTBY command #1819
Closed
PragmaTwice
PragmaTwice previously approved these changes Nov 26, 2023
View reviewed changes
@PragmaTwice
Copy link
Member

Could you check the clang-tidy report in CI and try to fix it?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@git-hulk git-hulk merged commit 04cf217 into apache:unstable Dec 1, 2023
30 checks passed
@julic20s julic20s mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.NUMMULTBY command Add support for the JSON.NUMINCRBY command
3 participants
@skyitachi @git-hulk @PragmaTwice