Allow to migrate cluster slot by raw write batch #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
reviewed
Jan 28, 2024
|
@caipengbo Great! Overall is quite clear and concise. Just a few questions inline. |
I have modified the question you mentioned before. Are there any other questions? @git-hulk |
git-hulk
reviewed
Jan 30, 2024
|
@caipengbo Sorry for didn't send out the comments. 😭 |
git-hulk
changed the title
git-hulk
approved these changes
Jan 30, 2024
|
JoverZhang
pushed a commit
to JoverZhang/kvrocks
that referenced
this pull request
Feb 24, 2024
This PR implemented the cluster slot migration by the rocksdb write batch, which will bring performance benefits. Also, we don't need to depend on parsing commands from the write batch log data if enabled. This makes the cluster migration feature more robust since we don't have to take care of the log data in each write batch. This closes apache#2008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemented the cluster slot migration by the rocksdb write batch, which will bring performance benefits. Also, we don't need to depend on parsing commands from the write batch log data if enabled. This makes the cluster migration feature more robust since we don't have to take care of the log data in each write batch.
This closes #2008 and the original PR is #1534