Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update actions to avoid Node.js deprecated warning #2098

Merged
merged 22 commits into from
Feb 15, 2024

Conversation

aleksraiden
Copy link
Contributor

Update all possible actions to latest version, because at spring 2024 all old actions, based on Nodejs 16 will be deprecated. See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Updates:

  • check-typos to v1.18.2
    • Add --sort flag
    • Protect against crash on multi-byte UTF-8 characters when parsed as ASCII
  • dorny/paths-filter to v3
    • Update NodeJS to 20
    • Update bump checkout action to v4 and use setup-node to setup node and cache npm deps
  • actions/setup-go to v5
    • Update NodeJS to 20
  • actions/cache to [v4] (https://github.com/actions/cache/releases/tag/v4.0.0)
  • docker/login-action to v3
    • Update NodeJS and all deps
  • docker/setup-qemu-action to v3
  • docker/setup-buildx-action to v3
  • docker/metadata-action to v5
    • Custom annotations support
    • Allow images input to be empty to output bare tags
    • Dedup and sort labels
  • docker/build-push-action to v5
    • Add annotations input
    • Add secret-envs input
    • Support for a minimal SLSA Provenance attestation
  • actions/github-script to v7
    • Avoid setting baseUrl to undefined when input is not provided
  • actions/setup-python to v5
  • apache/skywalking-eyes to v5
    • add support for AGPL-3.0
    • Upgrade go version to 1.18
    • New Header Template: GPL-3.0-or-later
    • Docker Multiple Architecture Support
  • actions/upload-artifact to v4
  • actions/setup-go to v5

Notes: In some job we use Centos 7 for run actions and this OS cant run Nodejs 20, so I revert in this case actions to old version. In a future, we need to change CentOS for continues work (e.g. before summer 2024)

Bump dorny/paths-filter to v3
Update actions/setup-go to v5
Update actions/cache to v4
Update docker/login-action to v3
Update docker actions: 
- docker/setup-qemu-action to v3
- docker/setup-buildx-action  to v3
- docker/metadata-action to v5
- docker/build-push-action to v5
Update actions/github-script to v7
Update actions/setup-python to v5
Update actions/setup-python to v5
Update apache/skywalking-eyes/header to 0.5.0
Update actions/upload-artifact to v4
Fix warning in actions/setup-go v5
Update docker/build-push-action to v5
Revert actions/cache@v4 to v3
@tisonkun tisonkun changed the title (CI) Update CI actions to avoid Nodejs deprecated warning ci: Update actions to avoid Node.js deprecated warning Feb 12, 2024
tisonkun
tisonkun previously approved these changes Feb 12, 2024
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

torwig
torwig previously approved these changes Feb 12, 2024
@tisonkun
Copy link
Member

dorny/paths-filter@v3 is not allowed to be used in apache/kvrocks.

You should open an ASF INFRA ticket to ask for whitelisting this action. I don't have my laptop around so you may search previous PRs to find related comments, or ask for @PragmaTwice @git-hulk help.

@git-hulk
Copy link
Member

git-hulk commented Feb 13, 2024

@aleksraiden I have filed a ticket to the ASF team to allow using dorny/paths-filter@v3, refer: https://issues.apache.org/jira/browse/INFRA-25491

cc @tisonkun

git-hulk
git-hulk previously approved these changes Feb 13, 2024
@git-hulk
Copy link
Member

@aleksraiden I have filed a ticket to the ASF team to allow using dorny/paths-filter@v3, refer: https://issues.apache.org/jira/browse/INFRA-25491

cc @tisonkun

dorny/paths-filter@v3 is ready to use now.

@PragmaTwice
Copy link
Member

Try to close and reopen for CI.

@PragmaTwice PragmaTwice reopened this Feb 14, 2024
@PragmaTwice
Copy link
Member

PragmaTwice commented Feb 14, 2024

dorny/paths-filter@v3 is ready to use now.

Nope. From the conversation, we need to use v3.0.0 instead of v3.

@git-hulk
Copy link
Member

git-hulk commented Feb 14, 2024

dorny/paths-filter@v3 is ready to use now.

Nope. From the conversation, we need to use v3.0.0 instead of v3.

I saw the v3 branch is referred to as v3.0.0, so it should be good to use v3.

https://github.com/dorny/paths-filter/tree/v3

@PragmaTwice
Copy link
Member

dorny/paths-filter@v3 is ready to use now.

Nope. From the conversation, we need to use v3.0.0 instead of v3.

I saw the v3 branch is referred to as v3.0.0, so it should be good to use v3.

https://github.com/dorny/paths-filter/tree/v3

It is not related to "refer", instead it is just regex matching.

v3 and v3.0.0 is different.

@PragmaTwice
Copy link
Member

PragmaTwice commented Feb 14, 2024

Also, you can see the current CI status. It cannot be started.

Seems the workflow file is not updated.

Try to use dorny/paths-filter v3.0.1
@aleksraiden aleksraiden dismissed stale reviews from git-hulk, tisonkun, and torwig via 07f6a2d February 15, 2024 09:00
@aleksraiden
Copy link
Contributor Author

Try to use dorny/paths-filter v3.0.1

@tisonkun
Copy link
Member

If I get it correctly, you should use exactly v3.0.0

@aleksraiden
Copy link
Contributor Author

Thanks @tisonkun and @PragmaTwice I fix version to v3.0.0 and all CI jobs are runned OK as I see

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 444976a into apache:unstable Feb 15, 2024
31 checks passed
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants