Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to use the redis command migration type if the target don't support the ApplyBatch command #2117

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Fallback to use the redis command migration type if the target don't support the ApplyBatch command #2117

merged 7 commits into from
Feb 28, 2024

Conversation

caipengbo
Copy link
Contributor

This close #2078

@caipengbo
Copy link
Contributor Author

When #2123 is merged (fix a bug about COMMAND command), the unit tests will be passed :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.7% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@git-hulk git-hulk changed the title Fall back to redis-command data migration type when the destination does not support ApplyBatch command Fallback to use the redis command migration type if the target don't support the ApplyBatch command Feb 28, 2024
@git-hulk git-hulk merged commit 019faed into apache:unstable Feb 28, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use redis-command data migration type when the destination does not support ApplyBatch command
3 participants
@caipengbo @git-hulk @PragmaTwice