Feat: add support of XPENDING #2190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiuYuHui
commented
Mar 30, 2024
Yangsx-1
reviewed
Mar 31, 2024
| StreamConsumerMetadata consumer_metadata = decodeStreamConsumerMetadataValue(get_consumer_value); | ||
| consumer_metadata.pending_number -= 1; | ||
|
|
||
| batch->Put(stream_cf_handle_, consumer_key, encodeStreamConsumerMetadataValue(consumer_metadata)); | ||
| batch->Delete(stream_cf_handle_, entry_key); |
There was a problem hiding this comment.
I think this line should be put after *acknowledged += 1 , because the entry_key may not be delete due to the early return.
jihuayu
reviewed
Apr 1, 2024
| const std::string &group_name = options.group_name; | ||
| std::string ns_key = AppendNamespacePrefix(stream_name); | ||
|
|
||
| LockGuard guard(storage_->GetLockManager(), ns_key); |
Comment on lines
+69
to
+70
| rocksdb::Status GetPendingEntries(StreamPendingOptions &options, StreamGetPendingEntryResult &pending_infos, | ||
| std::vector<StreamGetExtPendingEntryResult> &ext_results); |
There was a problem hiding this comment.
options here can be const.
The signature of this function is different from what we are accustomed to.
- We are accustomed to using pointers instead of references to represent return values.
- In general, we usually have only one return value.
- We usually place the key name(here is stream_name), group_name, consumer_name outside instead of inside the options.
| @@ -23,11 +23,14 @@ | |||
| #include <rocksdb/status.h> | |||
|
|
|||
| #include <memory> | |||
| #include <unordered_set> | |||
|
|
@LiuYuHui Hi, how's it going now? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1734