Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): allow to omit ON HASH|JSON in FT.CREATE #2484

Merged
merged 4 commits into from
Aug 10, 2024
Merged

feat(search): allow to omit ON HASH|JSON in FT.CREATE #2484

merged 4 commits into from
Aug 10, 2024

Conversation

PragmaTwice
Copy link
Member

The default data type is HASH, same as in Redis.

@git-hulk
Copy link
Member

LGTM, we can add a test case to avoid unexpected changes on this?

@PragmaTwice
Copy link
Member Author

LGTM, we can add a test case to avoid unexpected changes on this?

Done.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
59.4% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit 3408318 into apache:unstable Aug 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @git-hulk