-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add slow flags for commands with heavy disk I/O #2494
Conversation
@jonathanc-n What this issue intends to add a command attribute like what we have in commands/commander.h#L66. cc @PragmaTwice And for the slow commands:
|
@git-hulk Alright got it, thanks for the feedback! |
@git-hulk Are you able to check if this looks good? Thank you in advance! |
Co-authored-by: hulk <[email protected]>
@git-hulk Thanks for the review, sorry about the messy PR. I will make sure it is better in the future. |
@jonathanc-n A few new comments, rest are good to me. Thank you. |
Co-authored-by: hulk <[email protected]>
Co-authored-by: hulk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is not enough, some command in kvrocks don't have a good implementation, so it's not slow in redis but slow in kvrocks
However, we can move forward firstly
Quality Gate passedIssues Measures |
I have added slow flags for the following commands:
I would like to just see if I had done these correctly, I am looking to add support for these commands as well (please verify if these seem to be commands that contribute to heavy disk I/O + lmk if there are more to add):
References: #2474