fix(replication): didn't resume the db status after restarting full sync #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `pre_fullsync_cb` will stop the task runner and set the db loading status to yes, but it didn't resume those states. And will cause the server running in restoring status until success to resync from master. To fix this, we need to call the `post_fullsync_cb` to resume those status before restarting full sync. This PR also uses try_lock to allow to stop the replication thread while preparing the restore db.
PragmaTwice
approved these changes
Sep 21, 2024
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pre_fullsync_cbwill stop the task runner and set the DB loading status to yes, but it didn't resume those states. This will cause the server to run in restoring status until success in resyncing from the master. To fix this, we need to call thepost_fullsync_cbto resume those statuses before restarting full sync.This PR also uses try_lock to allow the replication thread to be stopped while preparing the restore db.
This closes #2511