Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more functional to cloudstack driver: #36

Closed
wants to merge 59 commits into from
Closed

Add more functional to cloudstack driver: #36

wants to merge 59 commits into from

Conversation

gigimon
Copy link
Contributor

@gigimon gigimon commented Nov 7, 2011

  1. work with firewall rules more flexible
  2. keypair work
  3. fix poolling driver
  4. register as provider

@Kami
Copy link
Member

Kami commented Nov 8, 2011

Thanks for this patch and a bug report!

While reviewing and testing your patch I also found some bugs myself and I have merged your bug fixes and mine into trunk today - https://github.com/apache/libcloud/commits/trunk.

I also wanted to include this fixes in the next release so I have canceled a vote for Libcloud 0.6.0 and started a new one for Libcloud 0.6.1 which includes those bug fixes.

For now I have also only merged essential bug-fixes, because I didn't want to introduce any new possible bugs which could creep in through the new features.

I will merge new features into trunk as soon as you add tests for them.

If you need help with writing the tests, let us know (Writing tests and using the fixture framework page should also help you).

@gigimon
Copy link
Contributor Author

gigimon commented Nov 8, 2011

Ok, I'm write tests.
Thank You for fast reaction

* add list_locations to ktucloud
* start cloudstack tests
* add ex_list_snapshots to EC2 driver
* add ex_create_snapshot to EC2 driver
* add cloudstack snapshot works
* add create template for cloudstack
* add delete snapshots/volumes
* add create snapshot
* add delete snapshot
* add deregister image
* rename methods ex_list -> ex_describe in cloudstack
Conflicts:
	libcloud/compute/base.py
	libcloud/compute/drivers/cloudstack.py
	libcloud/compute/drivers/gce.py
	libcloud/test/compute/fixtures/cloudstack/deleteSSHKeyPair_default.json
	libcloud/test/compute/fixtures/cloudstack/listSSHKeyPairs_default.json
	libcloud/test/compute/test_gce.py
* fix methods in cloudstack
* merge
Conflicts:
	libcloud/compute/base.py
	libcloud/compute/drivers/cloudstack.py
	libcloud/compute/drivers/gce.py
	libcloud/test/compute/fixtures/cloudstack/deleteSSHKeyPair_default.json
	libcloud/test/compute/fixtures/cloudstack/listSSHKeyPairs_default.json
	libcloud/test/compute/test_gce.py
Conflicts:
	libcloud/compute/drivers/cloudstack.py
	libcloud/test/compute/fixtures/cloudstack/createPortForwardingRule_default.json
	libcloud/test/compute/fixtures/cloudstack/deletePortForwardingRule_default.json
	libcloud/test/compute/fixtures/cloudstack/listPortForwardingRules_default.json
Conflicts:
	libcloud/compute/base.py
	libcloud/compute/types.py
@gigimon
Copy link
Contributor Author

gigimon commented Oct 9, 2013

Hello

Sorry for delay :)
I'm use original driver for cloudstack from libcloud and fix some test problems, fix several bugs with cloudstack portforwarding rules and use more common style for names (key_name -> keyname). Please accept my changes for cloudstack

@gigimon gigimon closed this Oct 9, 2013
Kami pushed a commit to Kami/libcloud that referenced this pull request Oct 28, 2021
asfgit pushed a commit that referenced this pull request Jul 31, 2023
…d..d499194be

d499194be README: prep 1.0.8
cf52d21d8 Remove pin on requests (fixes #41) (#42)
3ac8fed01 README: prep 1.0.7 (#40)
f7e969538 requirements: constrain requests below 2.30 (#39)
28aa5e1be New issue templates (#37)
1abec09c8 action: replace `internal-be-careful-debug` (#36)
75edeacda README: prep 1.0.6 (#34)
666b1b883 Check that output file exists before opening (#33)

git-subtree-dir: .github/actions/gh-action-pip-audit
git-subtree-split: d499194be74aeb3bc7dbed3a224a87e1831132c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants