[3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar

[riwarek]

I see such exception:

Exception in thread "main" java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader.main(JarRsrcLoader.java:62)
Caused by: java.lang.NoClassDefFoundError: org/apache/logging/log4j/LogManager
        at a.b.log.Log.getLogger(Log.java:48)
        at a.b.SCoLog.handleInputParameters(SCoLog.java:93)
        at a.b.SCoLog.main(SCoLog.java:33)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        ... 2 more
Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.LogManager
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
        ... 6 more

when I tried to run app with jar-in-jar-loader created by Eclipse 2023-12 (using Oracle jdk21).

Content of MANIFEST.FM file is:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.10.14
Created-By: 21+35-LTS-2513 (Oracle Corporation)
Main-Class: org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader
Rsrc-Main-Class: a.b.SCoLog
Rsrc-Class-Path: ./ lib/log4j/log4j-api-3.0.-beta1.jar lib/log4j/log4j
 -core-3.0.-beta1.jar lib/log4j/log4j-plugins-3.0.-beta1.jar lib/jdate
 picker-1.3.4.jar
Class-Path: .

All expected files (including jars) are in places in main jar file.

Launching command is java -jar app.jar

[ppkarwasz]

@riwarek,

Thank you very much for the report. We'll look into that.

To add some context to other contributors, this was motivated by your question on SO. The failure of the jar-in-jar loader with Log4j 2.x is due to eclipse-jdt/eclipse.jdt.ui#1057, but for Log4j 3.x this can very well be a Log4j bug.

[riwarek]

@ppkarwasz
Yes you are right, this is the fork of my problem presented on SO.

[ppkarwasz]

@riwarek,

I can not reproduce the issue. I created a 2179_log4j_3.x in copernik-eu/bug-reproducibility/eclipse-jar-in-jar with a sample project. It works both from Maven and Eclipse.

I think Eclipse might be messing with the RsrcClasspath. You have:

Rsrc-Class-Path: ./ lib/log4j/log4j-api-3.0.-beta1.jar lib/log4j/log4j-core-3.0.-beta1.jar lib/log4j/log4j-plugins-3.0.-beta1.jar lib/jdatepicker-1.3.4.jar

whereas it should be:

Rsrc-Class-Path: ./ log4j-api-3.0.-beta1.jar log4j-core-3.0.-beta1.jar log4j-plugins-3.0.-beta1.jar jdatepicker-1.3.4.jar

[riwarek]

@ppkarwasz
No this is ok.
This is part of my ant script:

<!--this file was created by Eclipse Runnable JAR Export Wizard-->
	<!--ANT 1.7 is required                                        -->
	<!--creation of basic scolog.jar-->
	<target name="build of JAR" depends="preparation">
		<jar destfile="${OUT_DIR}\${APP_NAME}.jar">
			<manifest>
				<attribute name="Main-Class" value="org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader" />
				<attribute name="Rsrc-Main-Class" value="rmdev.scolog.SCoLog" />
				<attribute name="Class-Path" value="." />
				<attribute name="Rsrc-Class-Path" value="./ lib/log4j/log4j-api-3.0.-beta1.jar lib/log4j/log4j-core-3.0.-beta1.jar lib/log4j/log4j-plugins-3.0.-beta1.jar lib/jdatepicker-1.3.4.jar" />
				<!--<attribute name="Rsrc-Class-Path" value="./ lib/log4j/log4j-api-2.22.1.jar lib/log4j/log4j-core-2.22.1.jar lib/jdatepicker-1.3.4.jar" />-->
			</manifest>
			<zipfileset src="jar-in-jar-loader.zip" />
			<!--<zipfileset dir="${WORKSPACE_DIR}\${PROJECT_NAME}\production\additional_input\data" includes="**/*.*" prefix="data" />-->
			<zipfileset dir="${WORKSPACE_DIR}\${PROJECT_NAME}\lib" includes="**/*.jar" prefix="lib" />
			<fileset dir="../bin" />
		</jar>
	</target>

And this is structure of my libs in project:

And this is eclipse 'configure build path':

Simply speaking I forced all libs to be in /lib in uberjar to avioid mess caused by presence of jars in root of uberjar.

[riwarek]

Just for clarification, earlier I used this pattern with uberjar and I had proper results.
It worked with configuration log4j-api-2.2 and oracle jdk1.8

[riwarek]

This is my jar-in-jar-loader.zip
jar-in-jar-loader.zip

[ppkarwasz]

@riwarek,

You have a typo in your script:

<attribute name="Rsrc-Class-Path" value="./ lib/log4j/log4j-api-3.0.-beta1.jar lib/log4j/log4j-core-3.0.-beta1.jar lib/log4j/log4j-plugins-3.0.-beta1.jar lib/jdatepicker-1.3.4.jar" />

should be:

<attribute name="Rsrc-Class-Path" value="./ lib/log4j/log4j-api-3.0.0-beta1.jar lib/log4j/log4j-core-3.0.0-beta1.jar lib/log4j/log4j-plugins-3.0.0-beta1.jar lib/jdatepicker-1.3.4.jar" />

[riwarek]

FACEPALM
Damn - you are right! How could I miss it?!
This solves the issue with 3.0.0. Now I can runn app with success.

Anyway we can state that for jar-in-jar from newest eclipse everything works as expected. I'm sorry for bothering you wiht my blindness and thank you for your time.

[ppkarwasz]

These kind of typos are the most time consuming and frustrating.

My Ant is rusty, but there is a way to generate the Rsrc-Class-Path attribute base to the actual list of files.

Something like this should work:

<property name="libDir" location="${basedir}/lib" />
<zipfileset id="classpath" dir="${libDir}" includes="**/*.jar" prefix="lib" />
<pathconvert property="classpath.list" refid="classpath" dirsep="/" pathsep=" ">
        <map from="${libDir}" to="lib"/>
</pathconvert>

<target name="build of JAR" depends="preparation">
<jar destfile="${OUT_DIR}\${APP_NAME}.jar">
	<manifest>
		<attribute name="Main-Class" value="org.eclipse.jdt.internal.jarinjarloader.JarRsrcLoader" />
		<attribute name="Rsrc-Main-Class" value="rmdev.scolog.SCoLog" />
		<attribute name="Class-Path" value="." />
		<attribute name="Rsrc-Class-Path" value="./ ${classpath.list}" />
	</manifest>
	<zipfileset src="jar-in-jar-loader.zip" />
        <zipfileset refid="classpath" />
	<fileset dir="../bin" />
</jar>
</target>

[riwarek]

This is nice trick. Ideed, now typos are not so scare. Thank you for this info.