Split off YAML configuration into its own module #2142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
config-yaml
branch
from
44ee1c8
to
dafafe4
Compare
|
I rebase the PR on top of #2155, so that we can immediately remove Jackson. |
vy
approved these changes
Jan 5, 2024
This splits `YamlConfiguration` into its own module and removes `jackson-dataformat-yaml` from `log4j-core`'s optional dependencies.
|
This has actually been successfully merged. I just deleted the branch too soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
YamlConfigurationinto its own module and removes Jackson fromlog4j-core's optional dependencies.Changes
YamlConfigurationFactoryis moved to a newlog4j-config-yamlmodule together with YAML specific tests,log4j-core-testfrom YAML to XML, since the tests are not YAML specific,log4j2-2134.yaml, which was referenced inJiraLog4j2_2134Test, but in practice theDefaultConfigurationwas used instead.