PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) #13891
Conversation
…tructor variants, CHANGES.txt entries (apache#13845) (cherry picked from commit dab7311) Resolved Conflicts: lucene/CHANGES.txt
| @@ -47,6 +52,9 @@ API Changes | |||
| the entire segment should be scored. Subclasses that override the method should instead override its replacement. | |||
| (Luca Cavanna) | |||
|
|
|||
| * GITHUB#13757: For similarities, provide default computeNorm implementation and remove remaining discountOverlaps setters. | |||
| (Christine Poerschke, Adrien Grand, Robert Muir) | |||
There was a problem hiding this comment.
I am afraid is is now too late to modify the changelog for 9.12, as it's already been released?
There was a problem hiding this comment.
Yes, https://lucene.apache.org/core/9_12_0/changes/Changes.html cannot be modified but my understanding is that the addition of the missing entry here would be included in https://lucene.apache.org/core/9_12_1/changes/Changes.html in future then, with the 9.12.1 file including 9.12.0 and earlier content also. Whether or not that's worthwhile, hmm, subjective I guess.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
@cpoerschke would you mind getting this in, but backing out the changes to 9.12.0 section of the change log? |
(cherry picked from commit dab7311)
Resolved Conflicts:
lucene/CHANGES.txt