Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO in FSTCompiler#freezeTail. #13923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove TODO in FSTCompiler#freezeTail. #13923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac8e7ab
Remove TODO in FSTCompiler#freezeTail.
vsop-479 Oct 16, 2024
89a5d44
Update comment.
vsop-479 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws IOException {
// FSTEnum, Util, etc., have trouble w/ non-final
// dead-end states:

// TODO: is node.numArcs == 0 always false? we no longer prune any nodes from FST:
// node.numArcs == 0 happens on last node. But it is final, we still can remove node.numArcs
// == 0.
final boolean isFinal = node.isFinal || node.numArcs == 0;

// this node makes it and we now compile it. first,
Expand Down
Loading