Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOXIA-584] Rewrite .md and .markdown links to .html #14

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

jmones
Copy link
Contributor

@jmones jmones commented Jan 25, 2019

This implementation supports rewriting the following types of links:
(link to a)[a.md]
(link to xxx section in a)[a.md#xxx]
(link to a)[a.markdown]
(link to xxx section in a)[a.markdown#xxx]

@jmones
Copy link
Contributor Author

jmones commented Jan 25, 2019

I'm improving the solution a little bit more. Will create another pull request.

@jmones jmones closed this Jan 25, 2019
@hboutemy
Copy link
Member

notice: you can do this by just updating your branch, without closing this PR :)

if you can add a little unit test, that would be awesome

@jmones jmones deleted the DOXIA-584_rewrite_crosslinks branch January 25, 2019 13:52
@jmones jmones reopened this Jan 25, 2019
@jmones
Copy link
Contributor Author

jmones commented Jan 25, 2019

Hi Hervé. Now you can look at it. I implemented it as a regex and added some unit tests, as requested.
Don't hesitate to request any modifications.

@hboutemy
Copy link
Member

great work!!!
please merge the PR I just sent on your clone for unit tests formatting
then squash the commits
then I'll merge

@jmones jmones force-pushed the DOXIA-584_rewrite_crosslinks branch from 2daa71a to 5ac826e Compare January 25, 2019 17:27
[DOXIA-584] Rewrite .md and .markdown links to .html

[DOXIA-584] Reimplemented as regexp

[DOXIA-584] Added test for link rewrite at MarkdownParser level

[DOXIA-584] Cleaned up some checkstyle issues

[DOXIA-584] Corrected ortographical error

fixed formatting issues (no Checkstyle for tests but still useful)
@jmones jmones force-pushed the DOXIA-584_rewrite_crosslinks branch from 5ac826e to c7e54fa Compare January 25, 2019 17:28
@jmones
Copy link
Contributor Author

jmones commented Jan 25, 2019

Done. I hope it's ok (no much experience on this).
Please note that I had to update flexmark dependency in POM, as I needed newer version (i hope that's ok).
Finally, do you have plans to release soon?

@hboutemy hboutemy merged commit 20203d6 into apache:master Jan 25, 2019
@hboutemy
Copy link
Member

merged, thank you: great job
new Flexmark version still requires Java 7, then it's perfect
on releasing, there is no precise plan for the moment: I'll review in a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants