[MENFORCER-397] allow no rules #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad. Let me check. |
slawekjaranowski
requested changes
Jul 31, 2022
| /** | ||
| * Set this to "true" to cause a failure if there are no rules to execute | ||
| */ | ||
| @Parameter( property = "enforcer.failIfNoRules", defaultValue = "true" ) |
There was a problem hiding this comment.
Pleas add @since
Yes - I see that other parameters also has missing it ... we can fix for rest in separate PR
It is used for documentation: https://maven.apache.org/enforcer/maven-enforcer-plugin/enforce-mojo.html
Maybe documentation - similar to other, eg:
Flag to allow executions without rules.
Comment on lines
300
to
315
| public void testFailIfNoTests() | ||
| throws MojoExecutionException { | ||
| setupBasics( false ); | ||
| mojo.setFailIfNoRules( false ); | ||
| mojo.execute(); | ||
| } |
There was a problem hiding this comment.
please add some assertions, eg that log.warn was called only once with specific message and no more interactions on log
slawekjaranowski
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
attached is another
up-for-grabs. This PR allows no rules by adding afailIfNoRulesparameter. SettingsfailIfNoRulesto false will log a warning "No rules are configured" instead of throwing an exception. Default behaviour is to throw an exception if there are no rules configured. Like people are used to.A suitable test case has been added.
Feedback is welcome.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.