-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHARED-1412] Allow to customize Interpolator used by filter #104
Conversation
f25600b
to
b8318ee
Compare
@kwin is there an immediate use case for this ? which maven plugin will use it ? just curious... |
The use case for me is https://issues.apache.org/jira/browse/JCRVLT-757 (outside the Maven project). But I can imagine that for some advanced use cases also the |
is there anything you could do with this https://maven.apache.org/plugins/maven-resources-plugin/examples/custom-resource-filters.html ? |
The problem is I want the default filter behaviour, which is currently not reusable in custom filter (i.e. all the code from maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java Lines 74 to 181 in 9d528d0
maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java Lines 217 to 323 in 9d528d0
|
If there is no further input I will merge at the end of the week. |
b8318ee
to
9abcf84
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSHARED-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-its
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.