Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-4991] LegacyRepositorySystem#injectProxy(repositories, proxies) … #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michael-o
Copy link
Member

…doesn't evaluate non-proxy hosts

Remove empty override of 'it-defaults' profile because it breaks MNG-4645. It
still reliably on both cases because:
before MNG-4645) It relied on the fact that the override removes the global
settings Maven Central definition of 'file:target/null' while Maven internally
still added canonical Maven Central back.
with MNG-4645) The empty profile override completely removes Maven Central
definition which means that the mirror won't proxy a non-existing repository.

This closes #95

…doesn't evaluate non-proxy hosts

Remove empty override of 'it-defaults' profile because it breaks MNG-4645. It is
still reliable for both cases because:
before MNG-4645) It relied on the fact that the override removes the global
settings Maven Central definition of 'file:target/null' while Maven internally
still added canonical Maven Central back.
with MNG-4645) The empty profile override completely removes Maven Central
definition which means that the mirror won't proxy a non-existing repository.

This closes #95
@michael-o
Copy link
Member Author

@gnodet Is this and its ticket obsolete with the move of Central out of core?

@michael-o michael-o requested a review from gnodet July 11, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant