Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINVOKER-313] Get rid of maven-artifact-transfer - InstallMojo refactor #174

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

slawekjaranowski
Copy link
Member

  • refactor InstallMojo to use Resolver API
  • add possibility to configure scope for installing artifacts
  • remove maven-artifact-transfer and maven-common-artifact-filters from dependencies

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MINVOKER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MINVOKER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

- refactor InstallMojo to use Resolver API
- add possibility to configure scope for installing artifacts
- remove maven-artifact-transfer and maven-common-artifact-filters from dependencies
@slawekjaranowski slawekjaranowski merged commit 74de493 into master Jan 31, 2023
@slawekjaranowski slawekjaranowski deleted the MINVOKER-313 branch January 31, 2023 16:29
@gnodet gnodet added this to the 3.5.0 milestone Feb 10, 2023
copybara-service bot pushed a commit to google/auto that referenced this pull request Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with this message:
```
Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1]
```

Setting `localRepositoryPath` fixes this.

I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly.

RELNOTES=n/a
PiperOrigin-RevId: 510172220
copybara-service bot pushed a commit to google/auto that referenced this pull request Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with the message here:
```
Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1]
```

Setting `localRepositoryPath` fixes this.

I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly. But it has always been [recommended](https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#localRepositoryPath) to use a non-default `localRepositoryPath` anyway.

RELNOTES=n/a
PiperOrigin-RevId: 510172220
copybara-service bot pushed a commit to google/auto that referenced this pull request Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with the message here:
```
Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1]
```

Setting `localRepositoryPath` fixes this.

I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly. But it has always been [recommended](https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#localRepositoryPath) to use a non-default `localRepositoryPath` anyway.

RELNOTES=n/a
PiperOrigin-RevId: 510177767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants