Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to defaults for GHA maven verify #210

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Switch to defaults for GHA maven verify #210

merged 1 commit into from
Jan 1, 2024

Conversation

slachiewicz
Copy link
Member

No description provided.

@slachiewicz
Copy link
Member Author

I've been expecting to have here Java 21

@slawekjaranowski
Copy link
Member

slawekjaranowski commented Jan 1, 2024 •
edited
Loading

I've been expecting to have here Java 21

I think we can try 21 in shared actions in standard matrix today

@khmarbaise
Copy link
Member

khmarbaise commented Jan 1, 2024 •
edited
Loading

Does Spotless work with JDK 21 in the meantime?

Yes rechecked it works with JDK 21 (2.40.0)...

@slawekjaranowski
Copy link
Member

slawekjaranowski commented Jan 1, 2024 •
edited
Loading

Does Spotless work with JDK 21 in the meantime?

Yes rechecked it works with JDK 21 (2.40.0)...

Parent 41 has a workaround for Spotless and it is ready for JDK 21

@slachiewicz slachiewicz merged commit 8dc8168 into master Jan 1, 2024
39 checks passed
@slachiewicz slachiewicz deleted the slachiewicz-patch-1 branch January 1, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slachiewicz @slawekjaranowski @khmarbaise