Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-726] update to log4j 1.2.17 in dependency tree #242

Closed
wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Sep 21, 2023

Nuked log4j from my .m2/repo and veriifed that the sample project now only downloads 1.2.17 when generating javadoc with 3.6.1-SNAPSHOT with this patch

~/mvn-javadoc-issue-sample$ mvn javadoc:javadoc
[INFO] Scanning for projects...
[INFO] 
[INFO] ----------< com.writetoyogi.automation:maven-sample-project >-----------
[INFO] Building maven-sample-project 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] >>> maven-javadoc-plugin:3.6.1-SNAPSHOT:javadoc (default-cli) > generate-sources @ maven-sample-project >>>
[INFO] 
[INFO] <<< maven-javadoc-plugin:3.6.1-SNAPSHOT:javadoc (default-cli) < generate-sources @ maven-sample-project <<<
[INFO] 
[INFO] 
[INFO] --- maven-javadoc-plugin:3.6.1-SNAPSHOT:javadoc (default-cli) @ maven-sample-project ---
Downloading from central: https://repo.maven.apache.org/maven2/log4j/log4j/1.2.17/log4j-1.2.17.pom
Downloaded from central: https://repo.maven.apache.org/maven2/log4j/log4j/1.2.17/log4j-1.2.17.pom (22 kB at 38 kB/s)
[INFO] Configuration changed, re-generating javadoc.
[INFO] 
``

![image](https://github.com/apache/maven-javadoc-plugin/assets/1005544/3712f04f-6700-40de-af7e-72d1d93d6f0d)

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to just exclude it? Velocity is never invoked in this case here.

@elharo
Copy link
Contributor Author

elharo commented Sep 21, 2023

IT failure is likely related; investigating...

@elharo elharo closed this Sep 23, 2023
@michael-o michael-o deleted the MJAVADOC-726 branch July 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants