Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JXR-170] NullPointerException while parsing Java 15 multi-line String source #60

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

spannm
Copy link
Contributor

@spannm spannm commented Jul 24, 2022

This PR offers a fix for bug [JXR-170]. Summary of changes:

  • Add support for parsing sources with Java 15 multi-line Strings
  • Add JUnit test case
  • Implement toString on class BaseType
  • Require non-null name on BaseType construtor
  • Prevent construction of types with null name
  • Add version to maven-enforcer-plugin plugin to prevent failure of integration test JXR-143_nofork

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [JXR-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace JXR-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…g source

- Add support for parsing sources with Java 15 multi-line Strings
- Add JUnit test case
- Implement toString on class BaseType
- Require non-null name on BaseType construtor
- Prevent construction of types with null name
- Add version to maven-enforcer-plugin plugin to prevent failure of integration test JXR-143_nofork
@slawekjaranowski slawekjaranowski self-assigned this Jul 25, 2022
@slawekjaranowski slawekjaranowski merged commit 87995c6 into apache:master Jul 25, 2022
@slawekjaranowski
Copy link
Member

@sman-81 thanks

@spannm
Copy link
Contributor Author

spannm commented Jul 25, 2022

@sman-81 thanks

Thank you, too @slawekjaranowski

@spannm spannm deleted the sman-81-JXR-170 branch July 25, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants