Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRESOLVER-321] Make collection and visiting interruptable #380

Merged
merged 6 commits into from
Nov 27, 2023
Merged

[MRESOLVER-321] Make collection and visiting interruptable #380

merged 6 commits into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. [MRESOLVER-321] Make collection interruptable 

    Currently the two collection are not interruptable,
does not sense interruption directly, only by some
side-effect like IO. Moreover, the BF new collector
may enter a "busy loop" as we seen, true, it was
due bug, but nothing prevents us to have more bugs.

Make main loop in both collector detect thread interruption
and use global (per-collection) Args to carry state of
the, interruption effectively the whole ST or MT
collection.

---

https://issues.apache.org/jira/browse/MRESOLVER-321
    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    26c2c7e View commit details
    Browse the repository at this point in the history

  2. Visitor made interruptible as well.

    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ab2adb6 View commit details
    Browse the repository at this point in the history

  3. Visitor should NOT reset the interrupted 

    flag, just interrupt the work, and let
that be handled somewhere else (ie. collector)
    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    28db64e View commit details
    Browse the repository at this point in the history

  4. Give cause for RTEx

    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b3032ff View commit details
    Browse the repository at this point in the history

  5. Reformat

    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cc77615 View commit details
    Browse the repository at this point in the history

  6. Simplify UT

    @cstamas
    cstamas committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    93c2029 View commit details
    Browse the repository at this point in the history