[MRESOLVER-471] Resolver should be oblivious about scopes. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Resolver 1.x it defined scopes (that were redefined by consumer project Maven), leading to duplication and possible digression if Maven was about to support new dependency scopes. Moreover, Resolver 1.x also contained (based on these scopes) logic, "scope refinement", "scope derive to buildpath scope" and so on. All these logic just like the definition of scopes belong to consumer project: Maven. Resolver really cares about only one scope: "system", as dependencies in this scope should be handled very differently than others (have no POMs and just file presence should be checked on resolving them). --- https://issues.apache.org/jira/browse/MRESOLVER-471
This class will need to be moved to Maven maven-resolver-provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Resolver 1.x it defined scopes (that were redefined by consumer project Maven), leading to duplication and possible digression if Maven was about to support new dependency scopes. Moreover, Resolver 1.x also contained (based on these scopes) logic, "scope refinement", "scope derive to buildpath scope" and so on. All these logic just like the definition of scopes belong to consumer project: Maven.
Resolver really cares about only one scope: "system", as dependencies in this scope should be handled very differently than others (have no POMs and just file presence should be checked on resolving them).
https://issues.apache.org/jira/browse/MRESOLVER-471