[MWRAPPER-44] clean up MavenWrapperDownloader upon plugin execution

[nhojpatrick]

Should fix https://issues.apache.org/jira/browse/MWRAPPER-44.

[nhojpatrick]

So reading more documentation and have just discovered -Dtype. Should multiple mvnw[Debug][.cmd] be created, otherwise if you do mvn wrapper:wrapper -Dtype=bin it might try and execute MavenWrapperDownloader.class as a backup.

[nhojpatrick]

Okay change of plan, original patch was wrong as didn't understand apache's maven wrapper introduced distributionType. This patch now MavenWrapperDownloader.class before installing maven wrapper, and if distributionType is not 'source' it will as delete MavenWrapperDownloader.java.

[jorsol]

Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR #13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!

[nhojpatrick]

Hi @nhojpatrick, thanks for your PR, I already worked on this in the PR #13, it's a fairly large change with many other fixes, would you mind reviewing that PR to check if it works for you? Thanks!

Hi @jorsol your WrapperMojo.cleanup(Path) achieves the same results. I was going to create a clean up method myself but wanted to get the fix raised with the change raised with the simplest diff to review.

[slawekjaranowski]

@nhojpatrick It is still valid after last changes to code?

[nhojpatrick]

@slawekjaranowski i think it's still needed if you swap to source, it should delete the class. i just retested and i think it's still needed.