Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWRAPPER-147] mvnw.cmd fails to launch maven if username contains space #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebthom
Copy link

@sebthom sebthom commented Sep 4, 2024

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ X Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


Addresses https://issues.apache.org/jira/browse/MWRAPPER-147

Executing mvnw on Windows where the user name contains space results mvnw failing to launch Maven:

> mvnw
'C:\Users\John' is not recognized as an internal or external command,
operable program or batch file.
Cannot start maven from wrapper

This is a big annoyance esp. for first time users of Maven wrapper who have no clue whats going on.

@cstamas
Copy link
Member

cstamas commented Sep 4, 2024

@michael-o please take a look

@sebthom sebthom changed the title [MWRAPPER-146] mvnw.cmd fails to launch maven if username contains space [MWRAPPER-147] mvnw.cmd fails to launch maven if username contains space Sep 4, 2024
@sebthom
Copy link
Author

sebthom commented Sep 18, 2024

@slawekjaranowski can you please have a look?

@slawekjaranowski
Copy link
Member

I don't use windows so can not confirm ... but looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants