[MNG-7639] Add unit test for DefaultRepositorySystemSessionFactory#newRepositorySession #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wRepositorySession Signed-off-by: crazyhzm <[email protected]>
Signed-off-by: crazyhzm <[email protected]>
cstamas
approved these changes
May 5, 2023
gnodet
approved these changes
May 16, 2023
slachiewicz
approved these changes
May 16, 2023
slawekjaranowski
requested changes
May 16, 2023
| request.setLocalRepository(getLocalRepository()); | ||
|
|
||
| // native | ||
| System.setProperty("maven.resolver.transport", "native"); |
There was a problem hiding this comment.
I would like to not change system properties - it can have impact on other test.
We can simply copy system properties to own instance and use it for test.
Maybe we need only one property for this test?
There was a problem hiding this comment.
@slawekjaranowski
Agreed. I have revised this part.
Signed-off-by: crazyhzm <[email protected]>
|
@CrazyHZM - please select checkboxes (at least one) about license acknowledge |
Done. |
slawekjaranowski
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.