[MNG-8005] do not ignore ide WorkspaceReader

[jonasrutishauser]

This change should fix the regression introduced by https://github.com/apache/maven/pull/963/files#diff-c14736c8f0b57d9f26af7f81fff3114a217edbed2b42049aa3c746ddab38966eR245-R250

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[gnodet]

@jonasrutishauser I don't really see what's broken with the mentioned commit...
Support for additional workspace readers has already been added through gnodet@a472975

The IDE workspace reader is already injected in the repository system session:

maven/maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java

Line 156 in 732e364

@Nullable @Named("ide") WorkspaceReader workspaceRepository,

[gnodet]

@jonasrutishauser an IT would be welcomed

[jonasrutishauser]

As requested I added a test: apache/maven-integration-testing#332

[jonasrutishauser]

The IDE workspace reader is already injected in the repository system session:

maven/maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java

Line 156 in 732e364

@Nullable @Named("ide") WorkspaceReader workspaceRepository,

That's correct, but this injected reader is directly overwritten:

maven/maven-core/src/main/java/org/apache/maven/DefaultMaven.java

Lines 417 to 422 in 732e364

	private CloseableSession newCloseableSession(MavenExecutionRequest request, WorkspaceReader workspaceReader) {
	return repositorySessionFactory
	.newRepositorySessionBuilder(request)
	.setWorkspaceReader(workspaceReader)
	.build();
	}

[cstamas]

Proposed PR that is a bit broader (but performs bigger and IMHO "proper" cleanup in this area): #1385