[MNG-8059] Paths everywhere #1413
Conversation
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
|
@cstamas Seems my idea does work? |
|
@michael-o unsure, did you change anything that is in this PR? Maybe drive letter matters? As CI keeps talking about |
Didn't touch a bit. For me, your chagne runs locally with Java 11. |
|
Hm, I think CI uses Java 11 as well? 🤷 |
|
This change is undone in resolver: "system" artifact can be ONLY a regular file that exists. |
cstamas
force-pushed
the
paths-everywhere
branch
from
3109ca9
to
6c0eb0f
Compare
| @@ -87,6 +87,6 @@ public boolean equals(Object obj) { | |||
| } | |||
|
|
|||
| UrlSource other = (UrlSource) obj; | |||
| return this.url.equals(other.url); | |||
| return Objects.equals(url.toExternalForm(), other.url.toExternalForm()); | |||
There was a problem hiding this comment.
url equality check performs hostname resolution
There was a problem hiding this comment.
Really? WTF?! Why not #toAsciiString()?
There was a problem hiding this comment.
Whatever, am just creating string out of both in same way and comparing the two.
Thanks. Sadly, this requires new alpha release of resolver (update + merge), so that is why would be good to have all Resolver PRs sorted out as I soon want to release it, to not have this PR rot for too long. |
Make execution flow never invoke path.toFile, at least what model-builder and maven-resolver-provider to make Resolver "paths everywhere" PR work. Depends on Resolver 2.0.0-alpha-8 release. --- https://issues.apache.org/jira/browse/MNG-8059
cstamas
force-pushed
the
paths-everywhere
branch
from
e11e8dd
to
9ff4c32
Compare
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/maven/repository/internal/MavenSessionBuilderSupplier.java
Outdated
Show resolved
Hide resolved
...n-resolver-provider/src/main/java/org/apache/maven/repository/internal/type/DefaultType.java
Outdated
Show resolved
Hide resolved
Make execution flow never invoke path.toFile, at least what model-builder and maven-resolver-provider matters.
https://issues.apache.org/jira/browse/MNG-8059