[MNG-8012] Warn if in-reactor BOM import happens #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be in fact prevented. --- https://issues.apache.org/jira/browse/MNG-8012
gnodet
reviewed
Mar 1, 2024
| @@ -1830,6 +1845,15 @@ private org.apache.maven.api.model.DependencyManagement doLoadDependencyManageme | |||
| return null; | |||
| } | |||
|
|
|||
| if (importSource instanceof FileModelSource && request.getRootDirectory() != null) { | |||
| URI sourceUri = ((FileModelSource) importSource).getLocationURI(); | |||
| if (request.getRootDirectory().toUri().relativize(sourceUri) != sourceUri) { | |||
There was a problem hiding this comment.
Fwiw, this test is unintuitive... a comment would be welcomed. I had to check the javadoc...
Or maybe using FileModelSource#getPath() instead or URIs ?
There was a problem hiding this comment.
I don't want to be pushy, but what about the following ?
Path sourcePath = ((FileModelSource) importSource).getPath();
if (sourcePath.startsWith(request.getRootDirectory()) {
There was a problem hiding this comment.
Pushed, so who's pushy now?
|
I believe this implementation is incomplete. It does not discern between a BOM (a module which manages the versions of the modules in the reactor) and a dependency management module (a module which manages the versions of external libraries used in the reactor).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be in fact prevented.
Also, model builder missed File uses are corrected.
https://issues.apache.org/jira/browse/MNG-8012