Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8088] Using Resolver with MRESOLVER-512 #1442

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Mar 15, 2024

This makes all the new scopes implemented out of the box, but MNG-8041 still stands (is unsolved).

Related PR apache/maven-resolver#445


https://issues.apache.org/jira/browse/MRESOLVER-512
https://issues.apache.org/jira/browse/MNG-8088

@cstamas cstamas self-assigned this Mar 15, 2024
@cstamas
Copy link
Member Author

cstamas commented Mar 23, 2024

@gnodet ported over changes happened in apache/maven-resolver#445 : removal of system scope handler.

@cstamas
Copy link
Member Author

cstamas commented Mar 23, 2024

Added both scope manager config to maven4.

IMO, when mvn4 builds mvn3 project (model Ver 4.0.0), it should use mvn3 scope manager, but when uses newer model, it should use mvn4 scope manager. But, Maven4 should always use scope manager, to not let Resolver 2 fallback to "legacy" mode.

now maven4 can work "as maven3" but can also support new
mvn4 scopes as well (per session).
@cstamas cstamas changed the title [EXPERIMENT] Using Resolver with MRESOLVER-512 [MNG-8088] Using Resolver with MRESOLVER-512 Mar 27, 2024
@cstamas cstamas marked this pull request as ready for review March 27, 2024 10:55
The spec branch deploy is not needed anymore,
PR in Resolver is merged.
@cstamas cstamas merged commit 2594047 into apache:master Mar 27, 2024
13 checks passed
@cstamas cstamas deleted the MRESOLVER-512 branch March 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants